Merge pull request #327 from rkpattnaik780/add_env_var

fix: add GIT_SSL_CAINFO env variable in odh-notebook-controller
opendatahub-io · May 15, 2024 · 739d427 · 739d427
2 parents ee20d44 + b3be81d
commit 739d427
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/components/odh-notebook-controller/controllers/notebook_controller.go b/components/odh-notebook-controller/controllers/notebook_controller.go
@@ -375,7 +375,7 @@ func (r *OpenshiftNotebookReconciler) UnsetNotebookCertConfig(notebook *nbv1.Not
 	log := r.Log.WithValues("notebook", notebook.Name, "namespace", notebook.Namespace)
 
 	// Get the notebook object
-	envVars := []string{"PIP_CERT", "REQUESTS_CA_BUNDLE", "SSL_CERT_FILE", "PIPELINES_SSL_SA_CERTS"}
+	envVars := []string{"PIP_CERT", "REQUESTS_CA_BUNDLE", "SSL_CERT_FILE", "PIPELINES_SSL_SA_CERTS", "GIT_SSL_CAINFO"}
 	notebookSpecChanged := false
 	patch := client.MergeFrom(notebook.DeepCopy())
 	copyNotebook := notebook.DeepCopy()

diff --git a/components/odh-notebook-controller/controllers/notebook_webhook.go b/components/odh-notebook-controller/controllers/notebook_webhook.go
@@ -335,6 +335,7 @@ func InjectCertConfig(notebook *nbv1.Notebook, configMapName string) error {
 		"REQUESTS_CA_BUNDLE":     configMapMountPath,
 		"SSL_CERT_FILE":          configMapMountPath,
 		"PIPELINES_SSL_SA_CERTS": configMapMountPath,
+		"GIT_SSL_CAINFO":         configMapMountPath,
 	}
 
 	notebookContainers := &notebook.Spec.Template.Spec.Containers