Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync] kserve/kserve-master to master branch #70

Merged
merged 22 commits into from
Sep 4, 2023
Merged

[Sync] kserve/kserve-master to master branch #70

merged 22 commits into from
Sep 4, 2023

Conversation

vaibhavjainwiz
Copy link
Member

@vaibhavjainwiz vaibhavjainwiz commented Aug 25, 2023

Motivation

This is Release Sync. Detail information is here:

  • Sync Date: 20230825
  • odh/kserve branch: master

related task : opendatahub-io/modelmesh-serving#173

sivanantha321 and others added 21 commits July 13, 2023 20:15
* Loosen ray range

Signed-off-by: ddelange <[email protected]>

* Fix import of RayServeHandle

ref ray-project/ray#34714

Signed-off-by: ddelange <[email protected]>

* Allow pandas 2.0

Signed-off-by: ddelange <[email protected]>

* Remove exclusion markers

Signed-off-by: ddelange <[email protected]>

* Run poetry lock --no-update

Signed-off-by: ddelange <[email protected]>

---------

Signed-off-by: ddelange <[email protected]>
…d` (kserve#3049)

* Create a separate action to free-up disk space on GH action runner
* Move 'free-up-disk-space' step outside 'minikube-setup' action
* Free-up disk space before running 'predictor-runtime-build'

Signed-off-by: Christian Kadner <[email protected]>
* Bump scikit-learn version to 1.3.0

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update test models

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Downgrade ray serve to 2.4

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* template out kube-rbac-proxy image

Signed-off-by: Tessa Pham <[email protected]>

* add kserve-addressable-resolver to clusterroles

Signed-off-by: Tessa Pham <[email protected]>

---------

Signed-off-by: Tessa Pham <[email protected]>
Except for Paddle, which does not support arm64/aarch64

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Add annotation for secret name overrides

Signed-off-by: Dan Sun <[email protected]>

* Remove the field

Signed-off-by: Dan Sun <[email protected]>

* Fix secret name annotation

Signed-off-by: Dan Sun <[email protected]>

* Update kserve url storage example docs

Signed-off-by: Dan Sun <[email protected]>

* Address review comments

Signed-off-by: Dan Sun <[email protected]>

* Update config docs for storage secret

Signed-off-by: Dan Sun <[email protected]>

* Fix storage secret name

Signed-off-by: Dan Sun <[email protected]>

* Add test for secret name annotation override

Signed-off-by: Dan Sun <[email protected]>

* Fix flake8 lint

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: Andrews Arokiam <[email protected]>
…serve#3069)

* document new status conditions

Signed-off-by: Tessa Pham <[email protected]>

* make generate

Signed-off-by: Tessa Pham <[email protected]>

* fix linting

Signed-off-by: Tessa Pham <[email protected]>

* remove requirements.txt in python

Signed-off-by: Tessa Pham <[email protected]>

* comment out unnecessary git checkout lines

Signed-off-by: Tessa Pham <[email protected]>

* indicate conditions for serverless mode only

Signed-off-by: Tessa Pham <[email protected]>

* go mod tidy

Signed-off-by: Tessa Pham <[email protected]>

---------

Signed-off-by: Tessa Pham <[email protected]>
The update was done by running the following commands in both the
project root and also inside `qpext/`:

```
go get -u golang.org/x/net/html
go mod tidy
```

This is to move away from CVE-2023-3978.

Signed-off-by: Edgar Hernández <[email protected]>
* Fix kserve kubeflow crd

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Generate kubeflow release artifact

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Use knative operator for installing knative in e2e tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Get logs for debugging

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Configure cni for minikube

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Upgrade minikube and knative operator

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix triton test fails due to insufficient resources

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix kourier namespace

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Use yaml configuration instead of knative cli

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Storage container CRD

Signed-off-by: Jin Dong <[email protected]>

* Add CRD to helm

Signed-off-by: Jin Dong <[email protected]>

* Add default CR

Signed-off-by: Jin Dong <[email protected]>

* Fix default storage container cr

Signed-off-by: Jin Dong <[email protected]>

* Update kserve-manager-role in helm charts

Signed-off-by: Jin Dong <[email protected]>

* Update crd format, modify controller code and tests

Signed-off-by: Jin Dong <[email protected]>

* Update helm charts

Signed-off-by: Jin Dong <[email protected]>

* fix cluster role

Signed-off-by: Jin Dong <[email protected]>

* Remove name from CRD

Signed-off-by: Jin Dong <[email protected]>

* Update CRD in helm

Signed-off-by: Jin Dong <[email protected]>

* Error handling

Signed-off-by: Jin Dong <[email protected]>

* Fix kubebuilder rbac annotation

Signed-off-by: Jin Dong <[email protected]>

* Add comments

Signed-off-by: Jin Dong <[email protected]>

* Fix test

Signed-off-by: Jin Dong <[email protected]>

* Update comments

Signed-off-by: Jin Dong <[email protected]>

---------

Signed-off-by: Jin Dong <[email protected]>
@israel-hdez
Copy link

@vaibhavjainwiz Can you link the ticket that this PR would be closing, or is related to?

@vaibhavjainwiz
Copy link
Member Author

@vaibhavjainwiz Can you link the ticket that this PR would be closing, or is related to?

done.. I had update the description of ticket to include related task.

@israel-hdez
Copy link

done.. I had update the description of ticket to include related task.

Perhaps, next time, create the ticket in this repo, instead of modelmesh-serving repo... or how this would be related to ModelMesh?

@vaibhavjainwiz
Copy link
Member Author

vaibhavjainwiz commented Aug 25, 2023

done.. I had update the description of ticket to include related task.

Perhaps, next time, create the ticket in this repo, instead of modelmesh-serving repo... or how this would be related to ModelMesh?

sure.. this time I just use github functionality to automatically create a GitHub issue for their sub-task so maybe it by default pick modelmesh-serving. I would take care of it going forward.

@vaibhavjainwiz
Copy link
Member Author

In PR checks only openshift-ci checks are failing because of permission issue on quay.io repos. We could ignore them because GitHub Actions are already taken care of it.

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, vaibhavjainwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [israel-hdez,vaibhavjainwiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link

/override ci/prow/pr-image-mirror-kserve-agent ci/prow/pr-image-mirror-kserve-controller ci/prow/pr-image-mirror-kserve-router

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

@israel-hdez: Overrode contexts on behalf of israel-hdez: ci/prow/pr-image-mirror-kserve-agent, ci/prow/pr-image-mirror-kserve-controller, ci/prow/pr-image-mirror-kserve-router

In response to this:

/override ci/prow/pr-image-mirror-kserve-agent ci/prow/pr-image-mirror-kserve-controller ci/prow/pr-image-mirror-kserve-router

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 833f509 into opendatahub-io:master Sep 4, 2023
@heyselbi heyselbi linked an issue Sep 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sync kserve repository(master branch)