Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-Pick][RHOAIENG-11034] - Disabling Authorino Token Authorization forces a Model Pod to rollout #444

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

spolti
Copy link
Member

@spolti spolti commented Nov 28, 2024

chore: Adds the security.opendatahub.io/enable-auth label to the ServiceAnnotationDisallowedList
to prevents the model to be rolled out in case the auth is disabled / enabled

Cherry-picks: #441

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

…odel Pod to rollout

chore:	Adds the `security.opendatahub.io/enable-auth` label to the ServiceAnnotationDisallowedList
	to prevents the model to be rolled out in case the auth is disabled / enabled

Signed-off-by: Spolti <[email protected]>
@openshift-ci openshift-ci bot requested review from hdefazio and rnetser November 28, 2024 20:01
Copy link

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwaykole, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spolti spolti merged commit 34ac4dc into opendatahub-io:release-v0.14 Nov 29, 2024
19 of 20 checks passed
@spolti spolti deleted the RHOAIENG-11034-014 branch November 29, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants