Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-13712] [CVE-2024-6119] - KServe - Type Confusion #414

Conversation

spolti
Copy link
Member

@spolti spolti commented Oct 2, 2024

chore: It is not a real fix, we just need to update the poetry.lock files
so the dependency version gets updated, in this case the cryptography
one was updated as expected to the suggested one.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

@spolti spolti requested review from Jooho and israel-hdez October 2, 2024 19:05
@openshift-ci openshift-ci bot requested a review from terrytangyuan October 2, 2024 19:06
@openshift-ci openshift-ci bot added the approved label Oct 2, 2024
Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is too invasive IMHO.

Rather than regenerating the whole .lock files, may you please do it with:

poetry update cryptography

It is going to update only what is essentially required in the lockfile and it is going to be easier to review.

chore:  It is not a real fix, we just need to update the poetry.lock files
        so the dependency version gets updated, in this case the cryptography
        one was updated as expected to the suggested one.

Signed-off-by: Spolti <[email protected]>
@spolti spolti force-pushed the RHOAIENG-13712-odh-rel branch from 658fb47 to 2a9f6d7 Compare October 3, 2024 18:50
@spolti
Copy link
Member Author

spolti commented Oct 3, 2024

Good idea @israel-hdez , updated.

Copy link

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Oct 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ca74f59 into opendatahub-io:release-v0.12.1 Oct 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants