Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-6878][Cherry-pick][RHOAI-2.10] fix: HPA equality check should include annotations (#3650) #355

Conversation

terrytangyuan
Copy link
Member

Cherry-picks kserve#3650.

* fix: HPA equality check should include annotations

Signed-off-by: Yuan Tang <[email protected]>

* Only watch related autoscalerclass annotation

Signed-off-by: Yuan Tang <[email protected]>

* simplify

Signed-off-by: Yuan Tang <[email protected]>

* Add missing delete action

Signed-off-by: Yuan Tang <[email protected]>

* fix logic

Signed-off-by: Yuan Tang <[email protected]>
---------

Signed-off-by: Yuan Tang <[email protected]>
@terrytangyuan terrytangyuan changed the title [RHOAIENG-6878][Cherry-pick] fix: HPA equality check should include annotations (#3650) [RHOAIENG-6878][Cherry-pick][RHOAI-2.10] fix: HPA equality check should include annotations (#3650) May 13, 2024
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [spolti,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7536608 into opendatahub-io:release-v0.12.1 May 13, 2024
18 checks passed
@terrytangyuan terrytangyuan deleted the odh-cp-hpa-delete branch May 13, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants