Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synch #264

Merged
merged 15 commits into from
Mar 7, 2024
Merged

Synch #264

merged 15 commits into from
Mar 7, 2024

Conversation

spolti
Copy link
Member

@spolti spolti commented Mar 7, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


ajstewart and others added 15 commits February 24, 2024 14:18
)

* Add model_version to InferResponse class

Signed-off-by: Adam Stewart <[email protected]>

* Update infer_type tests

Signed-off-by: Adam Stewart <[email protected]>

* Updated from_grpc class method argument ordering

Signed-off-by: Adam Stewart <[email protected]>

---------

Signed-off-by: Adam Stewart <[email protected]>
* set tensoor parallel to num of devices

Signed-off-by: Gavrish Prabhu <[email protected]>

* fix lint

Signed-off-by: Gavrish Prabhu <[email protected]>

---------

Signed-off-by: Gavrish Prabhu <[email protected]>
* Increase workers to 4

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* merge fast and slow

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Increase workers to 6 and merge explainer, transformer test

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Separate graph tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Change artifact upload/download action

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Use docker-container driver

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update all e2e tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Remove knative installation in raw tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix raw logger test

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Wait for model to be ready in mlserver e2e tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Cleanup markers

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Clean up workflow and upgrade actions

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Use worksteal dist type for pytest

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* fix typo

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Prettify pod log printing in status check

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add inference graph pod logs for debugging in status check

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Reorder Go docker files for better layer caching

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* rebase master

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* revert removal of time.sleep

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Fixed go lint error using golangci-lint tool.

Signed-off-by: Andrews Arokiam <[email protected]>

* go lint error fix

Signed-off-by: Andrews Arokiam <[email protected]>

* golint error fix for math/random

Signed-off-by: Andrews Arokiam <[email protected]>

* fix go tests and go-lint

Signed-off-by: Andrews Arokiam <[email protected]>

* commit for code review comments

Signed-off-by: Andrews Arokiam <[email protected]>

* fix for golint errcheck

Signed-off-by: Andrews Arokiam <[email protected]>

* gosec error fix

Signed-off-by: Andrews Arokiam <[email protected]>

---------

Signed-off-by: Andrews Arokiam <[email protected]>
Add new reviewers:
  - israel-hdez
  - terrytangyuan

Remove inactive reviewers:
  - adriangonz
  - iamlovingit
  - sukumargaonkar
  - theofpa
  - njhill

Signed-off-by: Christian Kadner <[email protected]>
* build: Add helm docs update to make generate command

Signed-off-by: Yuan Tang <[email protected]>

* pin versions

Signed-off-by: Yuan Tang <[email protected]>

* fix syntax

Signed-off-by: Yuan Tang <[email protected]>

* test

Signed-off-by: Yuan Tang <[email protected]>

* Update update-helm-docs.sh

Signed-off-by: Yuan (Terry) Tang <[email protected]>

* avoid flakiness

Signed-off-by: Yuan Tang <[email protected]>

* update version

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan (Terry) Tang <[email protected]>
* add async iter

* lint

* remove comment

* make fake stream data a var

* lint

* Update streaming tests

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* Upgrade orjson to version 3.9.15

chore: Fixes [CVE-2024-27454](https://nvd.nist.gov/vuln/detail/CVE-2024-27454): orjson.loads in orjson before 3.9.15 does not limit recursion for deeply nested JSON documents.

Signed-off-by: Spolti <[email protected]>

* Update python/kserve/pyproject.toml

Co-authored-by: Sivanantham <[email protected]>
Signed-off-by: Filippe Spolti <[email protected]>

* re-run poetry lock

Signed-off-by: Spolti <[email protected]>

---------

Signed-off-by: Spolti <[email protected]>
Signed-off-by: Filippe Spolti <[email protected]>
Co-authored-by: Sivanantham <[email protected]>
remove unnecessary settings from quick_install.sh

Removing the `useMCP` and `PILOT_ENABLE_CONFIG_DISTRIBUTION_TRACKING` as both of these already default to the values they are being set to.

Signed-off-by: Peter Jausovec <[email protected]>
kserve#3374)

* feat: add support for pydantic v2, tests for pydantic v1, and update dependencies

Signed-off-by: Timothy Laurent <[email protected]>

* feat: regenerate lock files

Signed-off-by: Timothy Laurent <[email protected]>

* feat: regenerate lock files with updates

Signed-off-by: Timothy Laurent <[email protected]>

* fix: update dependencies, fix broken tests

* feat: add special case for testing model ready, "True" for pydantic v1

* Update poetry lock

Signed-off-by: Dan Sun <[email protected]>

---------

Signed-off-by: Timothy Laurent <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
@spolti spolti requested a review from israel-hdez March 7, 2024 13:41
@openshift-ci openshift-ci bot requested a review from davidesalerno March 7, 2024 13:42
@openshift-ci openshift-ci bot added the approved label Mar 7, 2024
@spolti spolti requested review from terrytangyuan and removed request for davidesalerno March 7, 2024 13:42
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [spolti,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bc5ab20 into opendatahub-io:master Mar 7, 2024
28 checks passed
@spolti spolti deleted the synch branch March 7, 2024 17:42
Jooho pushed a commit to Jooho/kserve that referenced this pull request May 7, 2024
…tudio-kserve-controller-nightly

Red Hat Konflux update kserve-controller-nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.