Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: make build error with musl1.2.4 #357

Merged

Conversation

zztaki
Copy link

@zztaki zztaki commented Nov 23, 2023

Related this issue.

Fix make build error with musl1.2.4. This error is because LFS64 interfaces were marked as deprecated (release notes, commit).

@zztaki
Copy link
Author

zztaki commented Nov 23, 2023

In musl1.2.4, the legacy "LFS64" ("large file support") interfaces, which were provided by macros remapping them to their standard names (#define stat64 stat and similar) have been deprecated and are no longer provided under the _GNU_SOURCE feature profile, only under explicit _LARGEFILE64_SOURCE.

So, in this PR, I add _LARGEFILE64_SOURCE to CGO_CFLAGS and pass it to GOENV, which tells our program to use transitional LFS API explicitly for large file in go-sqlite3.

More related information can be seen in (release notes, commit).

@caoxianfei1
Copy link
Contributor

LGTM!

Copy link
Collaborator

@Wine93 Wine93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribute :)

@caoxianfei1 caoxianfei1 merged commit 580b26d into opencurve:develop Nov 23, 2023
3 checks passed
@zztaki
Copy link
Author

zztaki commented Nov 23, 2023

GLAD! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants