Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [curve/toos-v2]: add list client #2037 #2076

Merged
merged 1 commit into from
Nov 17, 2022
Merged

feat: [curve/toos-v2]: add list client #2037 #2076

merged 1 commit into from
Nov 17, 2022

Conversation

tsonglew
Copy link
Member

What problem does this PR solve?

Issue Number: #2037

Problem Summary:

add subcommand client in curve bs list

What's Changed:

image

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@tsonglew tsonglew mentioned this pull request Nov 15, 2022
Closed
@ilixiaocui ilixiaocui requested review from ilixiaocui, Cyber-SiKu and cw123 and removed request for Cyber-SiKu November 16, 2022 02:10
@ilixiaocui
Copy link
Contributor

It needs to be added that mdsaddr reads from the configuration file by default.

image

image

@cw123
Copy link
Contributor

cw123 commented Nov 16, 2022

add the list clientcommand to the tools-v2/README.md

@tsonglew
Copy link
Member Author

add the list clientcommand to the tools-v2/README.md

updated

@tsonglew
Copy link
Member Author

It needs to be added that mdsaddr reads from the configuration file by default.

image image

it looks good with my config files in the default dir

image

could you please leave a copy of your curve.yaml ?

@ilixiaocui
Copy link
Contributor

It needs to be added that mdsaddr reads from the configuration file by default.
image
image

it looks good with my config files in the default dir

image

could you please leave a copy of your curve.yaml ?

Sorry, it’s ok now, I just wrote the name of the configuration file as client.yaml.

LGTM!

@ilixiaocui
Copy link
Contributor

ilixiaocui commented Nov 16, 2022 •
edited
Loading

We are looking for developers to send out curve gift packages. Could you please add Curve’s WeChat?
image

@tsonglew tsonglew force-pushed the master branch 2 times, most recently from eba2ed2 to 9a72037 Compare November 16, 2022 10:43
Cyber-SiKu
Cyber-SiKu approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@Cyber-SiKu Cyber-SiKu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilixiaocui
Copy link
Contributor

recheck

@cw123
Copy link
Contributor

cw123 commented Nov 17, 2022

It is best to combine multiple git commits into one.

image

@Cyber-SiKu
Copy link
Contributor

recheck

@tsonglew
Copy link
Member Author

It is best to combine multiple git commits into one.

image

@cw123 PTAL

@Cyber-SiKu
Copy link
Contributor

recheck

@cw123 cw123 merged commit f856f13 into opencurve:master Nov 17, 2022
@zhanghuidinah zhanghuidinah mentioned this pull request Nov 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyber-SiKu Cyber-SiKu Cyber-SiKu approved these changes

@ilixiaocui ilixiaocui ilixiaocui approved these changes

@cw123 cw123 Awaiting requested review from cw123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsonglew @ilixiaocui @cw123 @Cyber-SiKu