-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency: copy external tap-go package as an internal package #766
Conversation
cc @klihub |
Move/copy external tap-go package from github.com/mndrix/tap-go to be in tree package. github.com/mndrix/tap-go is no longer maintained and it is currently archived. Also, bump gopkg.in/yaml.v2 to gopkg.in/yaml.v3. Signed-off-by: Muyassarov, Feruzjon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ping @mrunalp @kolyshkin |
(sorry for drive by comment) Instead of a straight copy/paste of the code, perhaps it would be good to migrate the code including history (see moby/sys#121 for an example) Perhaps also separating the integration commits from the follow ups (formatting build tags, upgrading yaml dependency) |
@thaJeztah sorry for my late response on this, I was on PTO. |
@fmuyassarov no worries! Also feel free to "ping" me if you need help with those instructions; I know it can be a bit of a pain to do (and make sure you use temporary repositories on your local machine), but I think it's good to a) preserve history (which can be relevant), and b) preserve the original commits to accredit the authors of those commits. |
+1 |
This PR fixes subset of the dependency issues described in #758.
Move/copy external tap-go package from github.com/mndrix/tap-go to be in tree package.
github.com/mndrix/tap-go is no longer maintained and it is currently archived. Also, bump
gopkg.in/yaml.v2 to gopkg.in/yaml.v3.