go.mod: Use toolchain 1.22.4 #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifubang
reviewed
Sep 20, 2024
AkihiroSuda
reviewed
Sep 20, 2024
rata
force-pushed
the
rata/min-1.22.4
branch
from
3b55c31 to
85fea21
Compare
AkihiroSuda
approved these changes
Sep 20, 2024
rata
force-pushed
the
rata/min-1.22.4
branch
from
85fea21 to
070d46f
Compare
Go since 1.21 allows to set a "toolchain" that specifies the minimum Go toolchain to use when working in runc. In contrast to the go line, toolchain does not impose a requirement on other modules[1][2]. As documented in the 1.2.0-rc.1 release notes, 1.22.4 is needed for the nsenter package. Let's suggest this with the toolchain version. [1]: https://go.dev/doc/toolchain [2]: https://go.dev/blog/toolchain Signed-off-by: Rodrigo Campos <[email protected]>
rata
force-pushed
the
rata/min-1.22.4
branch
from
070d46f to
319e133
Compare
|
@AkihiroSuda @lifubang PTAL |
lifubang
approved these changes
Sep 23, 2024
AkihiroSuda
approved these changes
Sep 23, 2024
rata
changed the title
|
Updated the PR title and description to match the changes, in case it is useful for the changelog later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go since 1.21 allows to set a "toolchain" that specifies the minimum Go toolchain to use when working in runc. In contrast to the go line, toolchain does not impose a requirement on other modules1.
As documented in the 1.2.0-rc.1 release notes, 1.22.4 is needed for the nsenter package. Let's suggest this with the toolchain version.