Add support for mapping leaf-lists of unions to protobufs. #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robshakir
commented
Nov 4, 2023
robshakir
commented
* (M) integration_tests/integration_test.go
- Reflect the fact that the gRIBI integration test cases is now
implemented.
* (M) protomap/proto.go
- Add support for mapping both []any and gNMI TypedValue messages
to fields within a protobuf from input gNMI paths.
* (M) protomap/testdata/...
- Additional fields in test protobufs.
wenovus
approved these changes
Nov 7, 2023
robshakir
added a commit
that referenced
this pull request
Nov 7, 2023
* Add support leaf-lists in paths->protobuf.
* (M) protomap/integration_tests/integration_test.go
- Add test case for a failure that was causing a panic,
where a leaf-list of union values was being handed to
PathsToProto. Currently not yet implemented, but test
checks error handling works as expected.
* (M) protomap/proto(_test)?.go
- Add support and testing for mapping of leaf-lists of
YANG inbuilt types to protobufs.
* Add TODO.
* Throw an error for `repeated` in `makeWrapper`.
* Add support for mapping leaf-lists of unions to protobufs. (#927)
* Add support for mapping leaf-lists of unions to protobufs.
* (M) integration_tests/integration_test.go
- Reflect the fact that the gRIBI integration test cases is now
implemented.
* (M) protomap/proto.go
- Add support for mapping both []any and gNMI TypedValue messages
to fields within a protobuf from input gNMI paths.
* (M) protomap/testdata/...
- Additional fields in test protobufs.
* Add outdated file.
* Remove stale output.
* Improve test coverage - add handling for bool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.