Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate ΛEnumTypes for shadow paths #917

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Generate ΛEnumTypes for shadow paths #917

merged 2 commits into from
Sep 28, 2023

Conversation

wenovus
Copy link
Collaborator

@wenovus wenovus commented Sep 27, 2023

  • Fixed unmarshalling union leafs for shadow paths.
  • Use correct path for keying ΛEnumTypes.
  • Re-generate exampleoc for schema test.

@wenovus
Generate ΛEnumTypes for shadow paths
80ace78 
* Fixed unmarshalling union leafs for shadow paths.
* Use correct path for keying `ΛEnumTypes`.
* Re-generate exampleoc for schema test.
@coveralls
Copy link

coveralls commented Sep 27, 2023 •
edited
Loading

Coverage Status

coverage: 89.522% (+0.002%) from 89.52% when pulling 2759bd6 on fix-unmarshal-union-shadowpath into 2224a32 on master.

DanG100
DanG100 approved these changes Sep 28, 2023
View reviewed changes
gogen/codegen.go Outdated Show resolved Hide resolved
ytypes/schema_tests/set_test.go Show resolved Hide resolved
@wenovus wenovus merged commit 23c9aac into master Sep 28, 2023
9 checks passed
@wenovus wenovus deleted the fix-unmarshal-union-shadowpath branch September 28, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

@robshakir robshakir Awaiting requested review from robshakir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenovus @coveralls @DanG100