Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generation flag for ordered maps #884

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Add generation flag for ordered maps #884

merged 1 commit into from
Jun 28, 2023

Conversation

wenovus
Copy link
Collaborator

@wenovus wenovus commented Jun 28, 2023

Flag is on by default to send a signal to downstream users to convert. The flag is used for transitioning existing code.

Tested generator manually. presubmit also has a test for it via integration_tests/schemaops and go generate ./...

  • Added integration test
  • Fixed a few typos

@wenovus wenovus requested review from robshakir and DanG100 June 28, 2023 17:37
@coveralls
Copy link

Coverage Status

coverage: 89.678% (+0.01%) from 89.664% when pulling 77a6250 on ordered-map-flag into efad7f9 on master.

@wenovus
Copy link
Collaborator Author

wenovus commented Jun 28, 2023

Thanks for the review!

@wenovus wenovus merged commit ec273a7 into master Jun 28, 2023
@wenovus wenovus deleted the ordered-map-flag branch June 28, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants