Uncompressed ordered map tests in mostly ygot package.
#872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comparing two GoStructs where a YANG `ordered-by user` list is involved, it is not possible using a single Notification to represent the diff such that the Notification can do the following: 1. update a gNMI cache correctly with the atomic notification. 2. unmarshal the notification to the `orig` to get back the `modified` GoStruct. This function achieves this functionality, sharing the underlying implementation with Diff, where a disclaimer has been added to the doc comment. Other helpers have been created as well to be shared with `TogNMINotifications`. Other changes: - `TogNMINotifications` has been changed to follow the same convention of putting the non-atomic Notification as the first message instead of the last. The reason is that current code MAY be using `notifs[0]` and I don't want to break that, and this also seems slightly better from a usability perspective.
* Simplified `UnmarshalSetRequest` to always unmarshal w/r to the root node. This allows atomic Notifications to be deleted correctly.
wenovus
changed the title
ygot package.ygot package.
DanG100
approved these changes
Jun 12, 2023
| @@ -50,3 +50,52 @@ func GetDeviceWithOrderedMap(t *testing.T) *Device { | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| func GetOrderedMap2(t *testing.T) *Ctestschema_OrderedLists_OrderedList_OrderedMap { | |||
There was a problem hiding this comment.
godoc
nit: i don't like "2" suffix, it's unclear what makes this func different from other func without looking at the code
There was a problem hiding this comment.
Thanks for the feedback, I've added a godoc. I think in this case it's ok to leave it like this rather than GetOrderedMapWeeWoo as the readers are mostly ygot maintainers and the code is fairly easy to understand. The "2" as a indicator for a different ordered map I think is sufficient. Let me know if you have other thoughts on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnmarshalSetRequestto always unmarshal w/r to the root node. This allows atomic Notifications to be deleted correctly.