Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interface{} -> any for render{_test}.go #855

Merged
merged 1 commit into from
Jun 2, 2023
Merged

interface{} -> any for render{_test}.go #855

merged 1 commit into from
Jun 2, 2023

Conversation

wenovus
Copy link
Collaborator

@wenovus wenovus commented Jun 2, 2023

Also converted some of the ConstructJSON tests to use the correct types which didn't affect the test result, which shows that pretty.Compare doesn't compare them correctly.

@wenovus
interface{} -> any for render{_test}.go
51ebf89 
Also converted some of the ConstructJSON tests to use the correct types
which didn't affect the test result, which shows that pretty.Compare
doesn't compare them correctly.
@coveralls
Copy link

Coverage Status

coverage: 89.728%. remained the same when pulling 51ebf89 on render-any into 92570aa on master.

@wenovus wenovus merged commit ff2fabb into master Jun 2, 2023
@wenovus wenovus deleted the render-any branch June 2, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcdomigan rcdomigan rcdomigan approved these changes

@shichuzhu shichuzhu shichuzhu approved these changes

@robshakir robshakir Awaiting requested review from robshakir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenovus @coveralls @shichuzhu @rcdomigan