Support unmarshalling an atomic Notification for ordered lists.
#851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Involves supporting `DeleteNode` at the container above the list for ordered maps.
|
Changes unknown when pulling 9a0eadf on support-unmarshal-notifs-orderedmaps into ** on master**. |
DanG100
approved these changes
Jun 1, 2023
| // matches the prefix. | ||
| // | ||
| // e.g. a/b partially matches a/b/c or a/b, but doesn't match a/c. | ||
| func PathPartiallyMatchesPrefix(path *gpb.Path, prefix []string) bool { |
There was a problem hiding this comment.
nit: somehow include that no keys are compared in the function name
| // | ||
| // e.g. a/b partially matches a/b/c or a/b, but doesn't match a/c. | ||
| func PathPartiallyMatchesPrefix(path *gpb.Path, prefix []string) bool { | ||
| for len(prefix) != 0 && prefix[len(prefix)-1] == "" { |
There was a problem hiding this comment.
when are there empty strings in path?
There was a problem hiding this comment.
This is just to guard against a trailing slash when splitting. I wouldn't have written this myself -- it is kept in uniformity with the existing PathMatchesPrefix
There was a problem hiding this comment.
This is just to guard against a trailing slash when splitting. I wouldn't have written this myself -- it is kept in uniformity with the existing PathMatchesPrefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Involves supporting
DeleteNodeat the container above the list for ordered maps.