Support a couple util/unmarshalling functions for ordered maps #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se it Ideally we generate this instead of handcrafting/copying it as it is subject to change and we want to be able to catch that. However the problem is because the generated code imports from ygot, it creates a circular dependency. There might be a way to address it but it should be made in a separate PR. This PR works around this by having a handcrafted copy that doesn't import from ygot. Later I will take a look at whether it's possible to move those ygot definitions to a base package and doing an alias.
Just have one unit test use it for now. Converting is very tedious since it requires all tests to move to a `_test` package to avoid circular dependency.
DanG100
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to an ordered list will error out if one already exists since it is expected to receive the whole of the ordered list elements as a whole instead of in chunks. If we later decide this is not the right behaviour we can relax the constraint.