perf(node): reduce reflect FieldByName and Field calls #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These calls are expensive to be put inside nested for loops. The performance can be improved if the results of these calls are cached.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
wenovus
reviewed
May 3, 2023
ytypes/node.go
Outdated
Comment on lines
438
to
440
| if !ok { | ||
| return nil, status.Errorf(codes.NotFound, "element struct type %v does not contain key field %s", listElemT, fieldName) | ||
| } |
There was a problem hiding this comment.
If you place this error statement above, then this error can be changed to say codes.Internal, and that it is expected that this field should always be populated.
There was a problem hiding this comment.
These are good suggestions, thanks. Changes made in the latest commit.
Resolve the comments in openconfig#829
wenovus
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reflectmethod calls are expensive to be put inside nested for-loops. The performance can be improved if the results of these calls are cached.Here are some rough reference numbers from e2e testing sending 2000 leaf-list updates in a SetRequest: