populateUpdate marshals JSON instead of TypedValue scalars #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gnmidiff for simplicity we want to have a uniform way of encoding values due to the chance that both JSON and TypedValue scalars can both be inputs at the same time. This means when diffing programmatically and visually (via CLI) the values can be compared apples-to-apples and it relieves the user of having to deal with type differences.
Previously
TogNMINotificationswas called which outputs scalars, but for uniformityMarshal7951is now used. There is actually no strict advantage to using TypedValue scalars due to the fact that YANG -> TypedValue conversion is lossy (namely all int/uint values get squished to int64/uint64), and so there is no way to accurately convert TypedValue scalar to JSON since int64/int32 are treated differently.Also double-val conversion is now done correctly (to string instead of float64)