Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow prefer config #136

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Allow prefer config #136

merged 4 commits into from
Nov 9, 2023

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Nov 8, 2023

  • Essentially just added a IsShadowPath() function alongside IsConfig() to allow generation/unmarshal to happen correctly.
  • Added simple bash script to copy ygnmi_test.go to ygnmi_preferconfig_test.go for testing.

This allows existing ygot code that prefers config paths to transition to using ygnmi.

@wenovus wenovus requested a review from DanG100 November 8, 2023 20:10
@coveralls
Copy link

coveralls commented Nov 8, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6805509420

  • 92 of 101 (91.09%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 82.305%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pathgen/pathgen.go 29 32 90.63%
pathgen/gnmigen.go 24 30 80.0%
Totals Coverage Status
Change from base Build 6805466690: 0.05%
Covered Lines: 2000
Relevant Lines: 2430
💛 - Coveralls

Base automatically changed from add-fakeroot-name-is-device-flag to main November 9, 2023 01:15
@wenovus wenovus merged commit af2a64f into main Nov 9, 2023
7 checks passed
@wenovus wenovus deleted the allow-prefer-config branch November 9, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenovus @coveralls @DanG100