Protect entryCache with lock
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ToEntry() is called concurrently after entryCache is cleared with ClearEntryCache(), then it is possible for a panic to occur as entryCache is being concurrently read/written. Fixes openconfig#261
wenovus
requested changes
Dec 19, 2023
sengleung
force-pushed
the
entrycache-lock-fix
branch
from
2261612 to
d521820
Compare
sengleung
force-pushed
the
entrycache-lock-fix
branch
from
d521820 to
d28b9ac
Compare
wenovus
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
ToEntry()is called concurrently afterentryCacheis cleared withClearEntryCache(), then it is possible for a panic to occur asentryCacheis being concurrently read/written.Fixes #261