Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize RPC input and output entries when augmented #250

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

karimra
Copy link
Contributor

@karimra karimra commented Sep 18, 2023

This PR fixes the issue raised in #247

Copy link
Collaborator

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing replying on the issue. This PR LGTM, one small suggestion.

Comment on lines +1350 to +1351
Dir: make(map[string]*Entry),
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind: InputEntry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +1358 to +1359
Dir: make(map[string]*Entry),
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind: OutputEntry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@coveralls
Copy link

Coverage Status

coverage: 83.76% (-0.3%) from 84.029% when pulling c32af44 on karimra:fix247 into 08bc968 on openconfig:master.

@wenovus wenovus merged commit 944052f into openconfig:master Sep 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants