-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common workflow #249
Use common workflow #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the linter configs need to be in this repo?
I didn't find a way to have the reusable workflow look at config files outside of this repo. So the only other way is cloning and replacing what's under .github/linters or generating them (if the files don't already exist) during the workflow. Doing this would also require the commit SHA/version of the common-ci repo to be provided as an If you look at the other PRs (see list at the description of openconfig/common-ci#2), most other repos use the I wasn't sure whether maintaining this extra complexity was worth it since I'm not certain which of the two So, the compromise I have is,
|
Makes sense to me. Thanks for the detailed explanation. |
No description provided.