Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OrderedByUser field #242

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Add OrderedByUser field #242

merged 4 commits into from
Apr 25, 2023

Conversation

wenovus
Copy link
Collaborator

@wenovus wenovus commented Apr 21, 2023

Per https://datatracker.ietf.org/doc/html/rfc7950#section-7.7.7 the field is either ordered by the user or it is not.

@wenovus wenovus requested a review from bormanp April 21, 2023 21:55
@coveralls
Copy link

coveralls commented Apr 21, 2023 •
edited
Loading

Coverage Status

Coverage: 84.021% (+0.02%) from 84.006% when pulling 3636f5b on ordered-by-user into fc70dac on master.

@wenovus wenovus requested a review from DanG100 April 24, 2023 22:28
@wenovus wenovus mentioned this pull request Apr 24, 2023
Merged
DanG100
DanG100 approved these changes Apr 25, 2023
View reviewed changes
pkg/yang/entry_test.go Outdated Show resolved Hide resolved
@wenovus wenovus merged commit 9a319ef into master Apr 25, 2023
@wenovus wenovus deleted the ordered-by-user branch April 25, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

@bormanp bormanp Awaiting requested review from bormanp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenovus @coveralls @DanG100