Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added modifier sub statement to pattern - rfc7950#section-9.4.5.1 #241

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

davidmat50
Copy link
Contributor

As per https://www.rfc-editor.org/rfc/rfc7950#section-9.4.5.1, pattern type should support 'modifier' sub statement.
I have made the changes to support 'modifier' for pattern.

@coveralls
Copy link

coveralls commented May 3, 2023

Coverage Status

coverage: 77.843% (-6.2%) from 84.006%
when pulling 2051120 on davidmat50:test-modifier-statemenet
into fc70dac on openconfig:master.

Copy link
Collaborator

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David, could you run gofmt on the file please?

@a-chartier
Copy link

Just curious if this functionality can be merged in at some point , It would be nice to have this functionality available.

@wenovus wenovus merged commit dfbf7ba into openconfig:master Jun 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants