Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MatchingEntryExtensions() to search extensions added during uses/augment/include statements #183

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Add MatchingEntryExtensions() to search extensions added during uses/augment/include statements #183

merged 1 commit into from
Jun 21, 2021

Conversation

wenovus
Copy link
Collaborator

@wenovus wenovus commented Jun 21, 2021 •
edited
Loading

MatchingExtensions currently takes in yang.Node, which is not quite usable when the user is mostly operating on yang.Entry objects.

I think the current MatchingExtensions implementation might still be useful in case the user wants to look into the extensions of non-Entry nodes, such as yang.Type.

@wenovus wenovus requested a review from robshakir June 21, 2021 19:56
@wenovus wenovus mentioned this pull request Jun 21, 2021
Open
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 76.562% when pulling f138ffb on matching-entry-extensions into 1580609 on master.

robshakir
robshakir approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@wenovus wenovus merged commit 1c554e3 into master Jun 21, 2021
@wenovus wenovus deleted the matching-entry-extensions branch June 21, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robshakir robshakir robshakir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenovus @coveralls @robshakir