Skip to content

Commit

Permalink
drm/i915/skl: Restore the DDI translation tables when enabling PW1
Browse files Browse the repository at this point in the history
I was dumping the DDI translation tables to make sure my patch updating
the HDMI entry was doing the right thing when I noticed that the table
was showing reset values after DPMS.

And indeed, the DDI translation registers are in power well 1 on SKL,
and so we're losing their values when shutting down eDP.

Calling intel_prepare_ddi() on PW1 enabling re-programs the table.

Reviewed-by: Paulo Zanoni <[email protected]>
Signed-off-by: Damien Lespiau <[email protected]>
Signed-off-by: Daniel Vetter <[email protected]>
  • Loading branch information
Damien Lespiau authored and danvet committed Mar 17, 2015
1 parent 2540039 commit 1d2b952
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/gpu/drm/i915/intel_runtime_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,10 @@ static void skl_power_well_post_enable(struct drm_i915_private *dev_priv,
1 << PIPE_C | 1 << PIPE_B);
}

if (power_well->data == SKL_DISP_PW_1)
if (power_well->data == SKL_DISP_PW_1) {
intel_prepare_ddi(dev);
gen8_irq_power_well_post_enable(dev_priv, 1 << PIPE_A);
}
}

static void hsw_set_power_well(struct drm_i915_private *dev_priv,
Expand Down

0 comments on commit 1d2b952

Please sign in to comment.