Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PC-Flash.md #1572

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create PC-Flash.md #1572

wants to merge 2 commits into from

Conversation

jaybaron1
Copy link

No description provided.

@jaybaron1
Copy link
Author

jaybaron1 commented Oct 20, 2021 via email

@jaybaron1 jaybaron1 changed the title Create PC-Flash-Jason.md Create PC-Flash.md Oct 21, 2021
@Foxy7
Copy link
Contributor

Foxy7 commented Dec 15, 2021

@danamlewis @jaybaron1 these instructions look good.

note i've not actually tested this on a rig, just read through them a couple of times.

couple of comments:

  1. The new instructions take you out of the main OpenAPS-Install page at step 1 and aren't linked back at the end of 1.7, so @jaybaron1 you need to add a link back in to rejoin the main instructions at https://openaps.readthedocs.io/en/latest/docs/Build%20Your%20Rig/OpenAPS-install.html#step-5-watch-your-pump-loop-log, i suggest this should be just before your section 2 for the "Advanced Installation Method".

  2. I'm not sure if we need the comment "Remember to set your prefences and adjust your settings: edit-pref" PC-flash.md#L373, since a first time install then they will need to move to step 5 to watch the pump loop log first. (note @jaybaron1 typo in "prefences")

  3. Would we need to remove this line "If you are using an Intel Edison, start with the Intel Edison instructions" from step 2 .https://github.com/openaps/docs/edit/master/docs/docs/Build%20Your%20Rig/OpenAPS-install.md#L30 ? since it's covered in the new instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants