Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bolus ack #14

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

bolus ack #14

wants to merge 3 commits into from

Conversation

bewest
Copy link
Member

@bewest bewest commented Oct 27, 2016

mmeowlink and Carelink stick do slightly different things:

  • Carelink always returns a payload, even when no payload exists,
    apparently to convey error status?
  • Mmeowlink exposes the acks per frame, but we observe no payload
    in the RF, therefore we generate a fictitious 64 byte null
    payload.

I've seen following successful fictious payloads from Carelink usb:
0x00 0x00
0x00
0x0c
0x00 0x0c

I've seen the following unsuccessful failure payloads from
Carelink usb (eg exceeding the max bolus limit):
0x09
0x09 0x09


Please do special testing on this, it's related to #4

mmeowlink and Carelink stick do slightly different things:
  * Carelink always returns a payload, even when no payload exists,
    apparently to convey error status?
  * Mmeowlink exposes the acks per frame, but we observe no payload
    in the RF, therefore we generate a fictitious 64 byte null
    payload.

I've seen following successful fictious payloads from Carelink usb:
  0x00 0x00
  0x00
  0x0c
  0x00 0x0c

I've seen the following unsuccessful failure payloads from
Carelink usb (eg exceeding the max bolus limit):
  0x09
  0x09 0x09
Try to fix spelling of receive.
Changed spelling of recieve to receive.
@scottleibrand
Copy link
Contributor

We should probably test this with SMB.

@scottleibrand
Copy link
Contributor

Looks like this will require updating the various bits of oref0 that accommodate the mis-spelling of receive, and general testing that it doesn't break anything. I think we'll probably want to start working on that right after we release oref0 0.5.0.

@scottleibrand
Copy link
Contributor

Turns out the "recieve" hack was already removed from oref0.

Created https://github.com/openaps/decocare/tree/0.1.0-dev and https://github.com/openaps/oref0/tree/decocare-0.1.0 to test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants