fix: runTools without stream should not emit user message events

openai · Aug 20, 2024 · 4162ba9 · 4162ba9
1 parent f1a4a68
commit 4162ba9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/src/lib/ChatCompletionRunFunctions.test.ts b/src/lib/ChatCompletionRunFunctions.test.ts
@@ -663,7 +663,6 @@ describe('resource completions', () => {
       await runner.done();
 
       expect(listener.messages).toEqual([
-        { role: 'user', content: 'tell me what the weather is like' },
         {
           role: 'assistant',
           content: null,
@@ -747,7 +746,6 @@ describe('resource completions', () => {
       await runner.done().catch(() => {});
 
       expect(listener.messages).toEqual([
-        { role: 'user', content: 'tell me what the weather is like' },
         {
           role: 'assistant',
           content: null,
@@ -893,10 +891,6 @@ describe('resource completions', () => {
       await runner.done();
 
       expect(listener.messages).toEqual([
-        {
-          role: 'user',
-          content: 'can you tell me how many properties are in {"a": 1, "b": 2, "c": 3}',
-        },
         {
           role: 'assistant',
           content: null,
@@ -1102,10 +1096,6 @@ describe('resource completions', () => {
       ]);
 
       expect(listener.messages).toEqual([
-        {
-          role: 'user',
-          content: 'can you tell me how many properties are in {"a": 1, "b": 2, "c": 3}',
-        },
         {
           role: 'assistant',
           content: null,
@@ -1199,7 +1189,6 @@ describe('resource completions', () => {
       ]);
 
       expect(listener.messages).toEqual([
-        { role: 'user', content: 'tell me what the weather is like' },
         {
           role: 'assistant',
           content: null,
@@ -1388,7 +1377,6 @@ describe('resource completions', () => {
       ]);
 
       expect(listener.messages).toEqual([
-        { role: 'user', content: 'tell me what the weather is like' },
         {
           role: 'assistant',
           content: null,

diff --git a/src/lib/ChatCompletionRunner.ts b/src/lib/ChatCompletionRunner.ts
@@ -59,8 +59,12 @@ export class ChatCompletionRunner extends AbstractChatCompletionRunner<ChatCompl
     return runner;
   }
 
-  override _addMessage(this: ChatCompletionRunner, message: ChatCompletionMessageParam) {
-    super._addMessage(message);
+  override _addMessage(
+    this: ChatCompletionRunner,
+    message: ChatCompletionMessageParam,
+    emit: boolean = true,
+  ) {
+    super._addMessage(message, emit);
     if (isAssistantMessage(message) && message.content) {
       this._emit('content', message.content as string);
     }