*: complete rust edition migrations #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extern crate is no longer needed, and #[macro_use] can be replaced by importing the macro directly. We already do this for most macros, but the bitflags usage came from the pre-2018 versions of libpathrs. Signed-off-by: Aleksa Sarai <[email protected]>
We can now move mod.rs to be <module_name>.rs which is easier to keep track of. However, in some cases it seemed nicer to remove the mod.rs file entirely and inline it in the upper module (this is especially nice for mod.rs files that are completely trivial and just define the list of submodules -- having to edit separate files is a bit of a waste of time). Signed-off-by: Aleksa Sarai <[email protected]>
We don't need to explicitly import it anymore. This is the only explicit import we had that got added to the prelude in Rust 2021. Signed-off-by: Aleksa Sarai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we switched to Rust 2021 a while ago (and Rust 2018 a while before
that), we still had some older Rust-isms that we could get rid of. So,
going through the Rust edition guides I've done all of the migrations
relevant to libpathrs, which should make the codebase feel a little more
modern.
Signed-off-by: Aleksa Sarai [email protected]