Timeouts on file downloads

open4good · Oct 9, 2024 · 1b7957f · 1b7957f
1 parent 759d991
commit 1b7957f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/commons/src/main/java/org/open4goods/commons/services/RemoteFileCachingService.java b/commons/src/main/java/org/open4goods/commons/services/RemoteFileCachingService.java
@@ -170,7 +170,8 @@ public File downloadToTmpFile(String url, String safeName) throws IOException {
         try {
             // Handle HTTP/HTTPS URLs
             if (url.startsWith("http")) {
-                FileUtils.copyURLToFile(new URL(url), destFile);
+            	//TODO(p3,conf) : timeouts from config
+                FileUtils.copyURLToFile(new URL(url), destFile, 30000, 30000);
             }
             // Handle classpath resources if necessary (currently commented out)
             // else if (url.startsWith(CLASSPATH_PREFIX)) {
@@ -281,7 +282,8 @@ public File download(final String url,final File tmpFile) throws TechnicalExcept
 
 		try {
 			logger.info("Downloading resource  from {} to {}", url, tmpFile);
-			FileUtils.copyURLToFile(new URL(url), tmpFile);
+        	//TODO(p3,conf) : timeouts from config
+            FileUtils.copyURLToFile(new URL(url), tmpFile, 30000, 30000);
 			return tmpFile;
 		} catch (Exception e) {
 			throw new TechnicalException("Cannot download resource " + url  + " : " + e.getMessage());