-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of DHCPV4 & Client and Server #361
Open
SuryyaKrJana
wants to merge
68
commits into
master
Choose a base branch
from
dhcp_support_pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes and stats
SuryyaKrJana
requested review from
apratimmukherjee,
alakendu,
SouravSinhaRoy,
PrasenjitAdhikary and
Vibaswan
March 13, 2024 05:25
…erator/models into dhcp_support_pr
…erator/models into dhcp_support_pr
SuryyaKrJana
requested review from
alakendu,
PrasenjitAdhikary,
apratimmukherjee and
das00003
March 27, 2024 10:53
…erator/models into dhcp_support_pr
…erator/models into dhcp_support_pr
das00003
approved these changes
Mar 28, 2024
PrasenjitAdhikary
approved these changes
Mar 28, 2024
…e session up & down state
…erator/models into dhcp_support_pr
…erator/models into dhcp_support_pr
…erator/models into dhcp_support_pr
…erator/models into dhcp_support_pr
alakendu
reviewed
Apr 4, 2024
@@ -0,0 +1,30 @@ | |||
components: | |||
schemas: | |||
DhcpServer.V4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name would be DhcpServer.V4Interface
which is align with BGP (Bgp.V4Interface
). Also this object acts like an interface.
Same also true for Dhcpv6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/open-traffic-generator/models/dhcp_support_pr/artifacts/openapi.yaml&nocors
_This model is designed to take care of following implementation: _
1. DHCP Client & Server are Keysight and Relay Agent as DUT:
In this the construct dhcp_v4interfaces and dhcp_v4interfaces are exposed under an Ethernet Interface to configure DHCP Client parameters. The configuration of a DHCP client is placed under Ethernet Interface as parallel to IP configuration as protocol like BGP can be configured referring an IP interface or a DHCP interface.
2. DHCP Client Behind the Relay Agent and are Keysight and DHCP Server as Keysight/DUT:
In this case DHCP client sits beside the Relay Agent that runs on top of connection Interfaces.
Hence new in chained_ethernet_name connection type in Connection under Ethernets Interface under the Device. This chained Ethernet can be linked to another chained Ethernet or a connected Ethernet interface.
dhcp_v4interface and dhcp_v4interface are exposed under a Chained Ethernet interface to configure DHCP Client parameters.
3. BGP peer can be configured on top of DHCP interface:
BGP peer is to refer ipv4_name or ipv6_name for IPv4/IPv6 connected or loopback interfaces. Now BGP peer can also refer to dhcp_v4interface or dhcp_v6interface interfaces.
_Please note that DHCPv6 Client & Server and V4/V6 Relay-Agent are just place holders to show position of these when will come into implementation. _
`
// Case-1: DHCP Client & Server are Keysight and Relay Agent as DUT.
// DHCPV4-Client(x.x.x.x)<-------> (1.1.1.1)RelayAgent(DUT)(2.2.2.1) <------>(2.2.2.2) DHCPV4-Server(Pool: 100.1.1.1)
// DHCP Client is configured on connected interface.
config := gosnappi.NewConfig()
// add ports
p1 := config.Ports().Add().SetName("p1").SetLocation(opts.IxiaCPorts()[0])
p2 := config.Ports().Add().SetName("p2").SetLocation(opts.IxiaCPorts()[1])
config := gosnappi.NewConfig()
// Port2 first chained device.
p2Lo1 := p2Chained1.Ipv4Loopbacks().
Add().
SetName("p2chaineddev1.v4lo1").
SetAddress("22.22.22.1").
SetEthName(d1Eth1.Name())