Add observable instruments to periodicreader tests #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2428 +/- ##
======================================
Coverage ? 79.5%
======================================
Files ? 122
Lines ? 21796
Branches ? 0
======================================
Hits ? 17338
Misses ? 4458
Partials ? 0 ☔ View full report in Codecov by Sentry. |
cijothomas
commented
Dec 14, 2024
| @@ -803,4 +803,134 @@ mod tests { | |||
| "Metrics should be available in exporter." | |||
| ); | |||
| } | |||
|
|
|||
| async fn some_async_function() -> u64 { | |||
There was a problem hiding this comment.
@howardjohn If you have bandwidth, could you review these? Asking since you helped fix some bugs in the area previously!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To cover various scenarios especially to show that callbacks doing asynchronous runtime specifics won't work well.