Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.23.1/v0.43.2 #4892

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 7, 2024

Fixed

  • Register all callbacks passed during observable instrument creation instead of just the last one multiple times in go.opentelemetry.io/otel/sdk/metric. (Fix callback registration bug #4888)

@MrAlias MrAlias marked this pull request as ready for review February 7, 2024 20:06
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11ebd19) 82.6% compared to head (4da346b) 82.6%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4892   +/-   ##
=====================================
  Coverage   82.6%   82.6%           
=====================================
  Files        232     232           
  Lines      18870   18870           
=====================================
  Hits       15603   15603           
  Misses      2977    2977           
  Partials     290     290           
Files Coverage Δ
bridge/opencensus/version.go 100.0% <100.0%> (ø)
...xporters/otlp/otlpmetric/otlpmetricgrpc/version.go 100.0% <100.0%> (ø)
...xporters/otlp/otlpmetric/otlpmetrichttp/version.go 100.0% <100.0%> (ø)
exporters/otlp/otlptrace/version.go 100.0% <100.0%> (ø)
sdk/metric/version.go 100.0% <100.0%> (ø)
sdk/version.go 100.0% <100.0%> (ø)
version.go 100.0% <100.0%> (ø)

@MrAlias MrAlias merged commit c5b112f into open-telemetry:main Feb 7, 2024
24 of 25 checks passed
@MrAlias MrAlias deleted the release-1.23.1 branch February 7, 2024 20:41
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants