-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdoutmetric: Add WithWriter and WithPrettyPrint options #4507
Merged
MadVikingGod
merged 6 commits into
open-telemetry:main
from
dmathieu:stdoutmetric-writer-prettyprint
Sep 27, 2023
Merged
stdoutmetric: Add WithWriter and WithPrettyPrint options #4507
MadVikingGod
merged 6 commits into
open-telemetry:main
from
dmathieu:stdoutmetric-writer-prettyprint
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
September 14, 2023 10:13
Codecov Report
@@ Coverage Diff @@
## main #4507 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 220 220
Lines 17679 17689 +10
=====================================
+ Hits 14384 14395 +11
+ Misses 2994 2993 -1
Partials 301 301
|
pellared
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that the PR tries to consolidate the two exporter stdout modules 👍
pellared
reviewed
Sep 22, 2023
pellared
changed the title
Add WithWriter and WithPrettyOptions to stdoutmetric
stdoutmetric: Add WithWriter and WithPrettyPrint options
Sep 22, 2023
pellared
approved these changes
Sep 22, 2023
hanyuancheung
approved these changes
Sep 26, 2023
@MadVikingGod PTAL |
MadVikingGod
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While stdoutmetric technically allows setting a custom writer with
WithEncoder
, using it means having to export the json package within an application, while stdouttrace exposes the quite simplerWithWriter
method.This PR therefore introduces
WithWriter
into stdoutmetric, so a writer other thanos.Stdout
can be passed easily.It also introduces
WithPrettyPrint
, so the package provides the same options as stdouttrace does.