Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes from PR 381 #443

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented Jan 24, 2020

These are some fixes I found in #381. This PR is to shrink #381 a bit.

@lizthegrey
Copy link
Member

ps @krnowak if you let maintainers edit your branches, it makes it easier to get things synced and promptly merged :)

@krnowak
Copy link
Member Author

krnowak commented Jan 27, 2020

ps @krnowak if you let maintainers edit your branches, it makes it easier to get things synced and promptly merged :)

Would love to, but for some reason this option not accessible for me neither here nor in PR creation page…

@lizthegrey
Copy link
Member

ps @krnowak if you let maintainers edit your branches, it makes it easier to get things synced and promptly merged :)

Would love to, but for some reason this option not accessible for me neither here nor in PR creation page…

Likely an org setting, try asking Kinvolk admins if they'll turn that option in in your repo

@krnowak
Copy link
Member Author

krnowak commented Jan 29, 2020

ps @krnowak if you let maintainers edit your branches, it makes it easier to get things synced and promptly merged :)

Would love to, but for some reason this option not accessible for me neither here nor in PR creation page…

Likely an org setting, try asking Kinvolk admins if they'll turn that option in in your repo

I asked the admins, they couldn't find anything in neither org settings nor in repo settings. Heck, I even cloned opentelemetry-go to my own test org to figure it out, but I also couldn't find it nor the option was available to me. I also cloned opentelemetry-go to my personal account and the "allow edits from maintainers" option was available. So I suppose that this option is only available for PRs made from the repos in personal accounts.

jmacd added 3 commits January 30, 2020 19:18
Unused. And confusing, since "ot" may mean "opentracing" as well.
@krnowak krnowak force-pushed the krnowak/misc-fixes branch from a0f1bec to e695cd1 Compare January 30, 2020 18:19
@krnowak
Copy link
Member Author

krnowak commented Jan 30, 2020

Rebased.

@rghetia rghetia merged commit 405a92a into open-telemetry:master Jan 30, 2020
@krnowak krnowak deleted the krnowak/misc-fixes branch January 30, 2020 18:45
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants