Make the AsType functions not panic #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
approved these changes
Nov 21, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3489 +/- ##
=====================================
Coverage 77.8% 77.9%
=====================================
Files 165 165
Lines 11614 11634 +20
=====================================
+ Hits 9044 9066 +22
+ Misses 2374 2372 -2
Partials 196 196
|
MrAlias
approved these changes
Nov 21, 2022
hanyuancheung
approved these changes
Nov 22, 2022
Signed-off-by: Aaron Clawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3488
This fixes any reflection panics related to calling AsTypeSlice() on attribute Values.