-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not export aggregations without any data points #3436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Nov 2, 2022
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
November 2, 2022 00:09
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3436 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 164 164
Lines 11520 11521 +1
=====================================
+ Hits 8952 8957 +5
+ Misses 2370 2368 -2
+ Partials 198 196 -2
|
MadVikingGod
approved these changes
Nov 4, 2022
dmathieu
approved these changes
Nov 11, 2022
hanyuancheung
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3394
Currently, the SDK exports histograms, last-values, and sums that do not contain any data points. This updates the aggregation implementations to return nil instead of values if that is the case. From there this will prevent empty data from being exported:
opentelemetry-go/sdk/metric/pipeline.go
Lines 134 to 135 in 49b62ae