-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds attribute filter logic #3396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
October 25, 2022 18:42
1 task
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
=======================================
- Coverage 77.8% 77.8% -0.1%
=======================================
Files 164 164
Lines 11494 11497 +3
=======================================
+ Hits 8944 8945 +1
- Misses 2347 2349 +2
Partials 203 203
|
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Oct 25, 2022
MrAlias
reviewed
Oct 27, 2022
MrAlias
approved these changes
Nov 3, 2022
hanyuancheung
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-adds the ability for a view to filter by attribute key.
This does expose a bug in the sum async aggregation with filtering.