-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong representation of status value in zipkin exporter #3340
fix wrong representation of status value in zipkin exporter #3340
Conversation
Status Code
name to fully upper case
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 164 164
Lines 11359 11361 +2
=====================================
+ Hits 8859 8861 +2
Misses 2301 2301
Partials 199 199
|
I'm not sure this is the proper fix. Even though I think the uppercasing should happen within the zipkin exporter, not for all codes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the uppercasing should happen within the zipkin exporter, not for all codes.
Agreed
0878205
to
62bd8a8
Compare
Thx, I didn't notice the side effect. New version of this fix has been submitted, please help do the further review. |
correct the usage of case-sensitive terms Co-authored-by: Tyler Yahn <[email protected]>
fix #3287
Set the name of span status code to upper case, from
Unset
,Ok
,Error
toUNSET
,OK
,ERROR
without making breaking changes. Previous version of code names can still be parsed.