Fix sdktrace.TraceProvider Shutdown/ForceFlush when no processor register #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
bogdandrutu
force-pushed
the
fixprovider
branch
2 times, most recently
from
2a1bf45 to
6339700
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3268 +/- ##
=====================================
Coverage 77.6% 77.7%
=====================================
Files 161 162 +1
Lines 11260 11255 -5
=====================================
+ Hits 8741 8747 +6
+ Misses 2319 2311 -8
+ Partials 200 197 -3
|
bogdandrutu
force-pushed
the
fixprovider
branch
from
6339700 to
fc76ac9
Compare
bogdandrutu
commented
Oct 11, 2022
| @@ -51,7 +51,7 @@ func (tr *tracer) Start(ctx context.Context, name string, options ...trace.SpanS | |||
|
|
|||
| s := tr.newSpan(ctx, name, &config) | |||
| if rw, ok := s.(ReadWriteSpan); ok && s.IsRecording() { | |||
| sps, _ := tr.provider.spanProcessors.Load().(spanProcessorStates) | |||
There was a problem hiding this comment.
Not sure, but this may also have caused a panic (someone else if really interested can investigate).
hanyuancheung
approved these changes
Oct 11, 2022
bogdandrutu
force-pushed
the
fixprovider
branch
from
fc76ac9 to
33cdc7c
Compare
MrAlias
reviewed
Oct 11, 2022
…ster Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
fixprovider
branch
from
33cdc7c to
460920a
Compare
MrAlias
approved these changes
Oct 12, 2022
MrAlias
reviewed
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.