-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Aggregation/Temporality selection to the Exporter interface #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Oct 4, 2022
MrAlias
force-pushed
the
exp-agg-tempor
branch
from
October 4, 2022 21:00
45a6398
to
a2af7a1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3260 +/- ##
=======================================
- Coverage 77.9% 77.7% -0.3%
=======================================
Files 164 164
Lines 11361 11457 +96
=======================================
+ Hits 8861 8909 +48
- Misses 2301 2346 +45
- Partials 199 202 +3
|
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod and
pellared
as code owners
October 18, 2022 21:05
MadVikingGod
approved these changes
Oct 31, 2022
dashpole
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenTelemetry specification defines the metric exporter interface as a type that defines the aggregation and temporality properties of the Metric SDK through the reader they are registered with:
Similar to the Java and Python, this updates the
Exporter
interface to handle this communication of values through their associated reader.Related to #3244