Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trace API config creation functions #2212

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 30, 2021

Follow our style guide and return the config struct instead of pointers. This will also allow a future change to address #2065 by updating the internal options interfaces.

Follow our style guide and return the config struct instead of pointers.
@MrAlias MrAlias added the bug Something isn't working label Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #2212 (dfe67e9) into main (361a209) will increase coverage by 0.0%.
The diff coverage is 82.3%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2212   +/-   ##
=====================================
  Coverage   72.9%   72.9%           
=====================================
  Files        176     176           
  Lines      12161   12162    +1     
=====================================
+ Hits        8867    8868    +1     
  Misses      3055    3055           
  Partials     239     239           
Impacted Files Coverage Δ
trace/config.go 63.7% <75.0%> (ø)
bridge/opentracing/internal/mock.go 67.0% <100.0%> (ø)
internal/global/trace.go 89.0% <100.0%> (+0.2%) ⬆️
sdk/trace/tracer.go 93.1% <100.0%> (ø)

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Aneurysm9 Aneurysm9 merged commit 1f527a5 into open-telemetry:main Sep 1, 2021
@MrAlias MrAlias deleted the non-ptr-trace-conf branch September 1, 2021 22:59
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants