Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for int32 in attribute.Any #2169

Merged
merged 5 commits into from
Aug 11, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 6, 2021

Part of #2162

Also, do not convert to an int just to have Int convert it back to int64.

@MrAlias MrAlias added the bug Something isn't working label Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #2169 (b3d2274) into main (2b0e139) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2169   +/-   ##
=====================================
  Coverage   72.3%   72.4%           
=====================================
  Files        176     176           
  Lines      12095   12093    -2     
=====================================
+ Hits        8755    8758    +3     
+ Misses      3102    3098    -4     
+ Partials     238     237    -1     
Impacted Files Coverage Δ
attribute/kv.go 90.0% <100.0%> (+4.2%) ⬆️
...s/otlp/otlptrace/internal/connection/connection.go 16.4% <0.0%> (+1.5%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 5d25c4d into open-telemetry:main Aug 11, 2021
@MrAlias MrAlias deleted the attr-int32-any branch August 11, 2021 16:32
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants