Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geneva] Tweak OtlpProtobufSerializer to access MetricPoint by ref #2310

Merged

Conversation

CodeBlanch
Copy link
Member

Changes

  • Fix a few spots in GenevaExporter where MetricPoint wasn't being accessed/passed by ref

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team as a code owner November 8, 2024 19:22
@github-actions github-actions bot added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (71655ce) to head (b6bfff5).
Report is 595 commits behind head on main.

Files with missing lines Patch % Lines
...eva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs 0.00% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2310       +/-   ##
==========================================
- Coverage   73.91%   0.00%   -73.92%     
==========================================
  Files         267      44      -223     
  Lines        9615    3899     -5716     
==========================================
- Hits         7107       0     -7107     
- Misses       2508    3899     +1391     
Flag Coverage Δ
unittests-Exporter.Geneva 0.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs 0.00% <0.00%> (ø)

... and 264 files with indirect coverage changes

Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit afe4342 into open-telemetry:main Nov 13, 2024
60 checks passed
@CodeBlanch CodeBlanch deleted the geneva-otlp-metricpoint-ref branch November 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants