-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percentage settings for memory limiter processor and ballast size #1078
Comments
The memory limiter is critical and difficult to enable by default -- agreed something like this is needed and must be in core. Even better if ballast size did not need to be set in two different places. |
@pavolloffay Can you clarify: percentage of what? Where do we get the total to calculate the fraction? |
The total amount of memory would be derived from the host environment. I haven't looked into this closely, but there should be a way to get total memory of the runtime. For example JDK supports this https://www.eclipse.org/openj9/docs/xxinitialrampercentage/ |
Is there any progress? Is somebody working on this? |
I have started working on this. |
* Update trace export interface Move to conforming to the specification. * Update documentation in export trace * Update sdk trace provider to support new trace exporter * Update SpanProcessors Support the Provider changes and new trace exporter. * Update the SDK to support the changes * Update trace Provider to not return an error * Update sdk with new Provider return Also fix the testExporter ExportSpans method * Update exporters with changes * Update examples with changes * Update Changelog * Move error handling to end of shutdown * Update exporter interface Rename to SpanExporter to match specification. Add an error return value to the Shutdown method based on feedback. Propagate these changes. Remove the Stop method from the OTLP exporter to avoid confusion and redundancy. * Add test to check OTLP Shutdown honors context * Add Jaeger exporter test for shutdown * Fix race in Jaeger test * Unify shutdown behavior and testing * Update sdk/trace/simple_span_processor.go Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]>
Is your feature request related to a problem? Please describe.
Flag
--mem-ballast-size-mib
and memory linter processor configuration accept absolute settings. This makes it hard to enable and configure these components in a default/hardcoded configuration. The percentage settings could be applied to a wide range of deployments and default values could be used.--mem-ballast-size-mib=2000
Describe the solution you'd like
Use percentages to set
--mem-ballast-size-mib
,ballast_size_mib
,limit_mib
andspike_limit_mib
. Thecheck_interval
could be set some optimal default value.Describe alternatives you've considered
Wrap the memory linter and dynamically calculate absolute values. However, it would be better to get this implemented directly in the core.
Additional context
Jaeger binaries would like to enable memory linter in the default configuration.
The text was updated successfully, but these errors were encountered: