feat: remove pointer usage

config/confighttp/confighttp.go

@@ -107,7 +107,7 @@ type ClientConfig struct {
 	Cookies *CookiesConfig `mapstructure:"cookies"`
 
 	// Maximum number of redirections to follow, if not defined, the Client uses its default policy, which is to stop after 10 consecutive requests.
-	MaxRedirects *int `mapstructure:"max_redirects"`
+	MaxRedirects int `mapstructure:"max_redirects"`
 }
 
 // CookiesConfig defines the configuration of the HTTP client regarding cookies served by the server.
@@ -132,6 +132,7 @@ func NewDefaultClientConfig() ClientConfig {
 		MaxIdleConnsPerHost: &defaultTransport.MaxIdleConnsPerHost,
 		MaxConnsPerHost:     &defaultTransport.MaxConnsPerHost,
 		IdleConnTimeout:     &defaultTransport.IdleConnTimeout,
+		MaxRedirects:        10,
 	}
 }
 
@@ -253,14 +254,10 @@ func (hcs *ClientConfig) ToClient(ctx context.Context, host component.Host, sett
 }
 
 // makeCheckRedirect checks if max redirects are exceeded
-func makeCheckRedirect(max *int) func(*http.Request, []*http.Request) error {
-	if max == nil {
-		return nil
-	}
-
+func makeCheckRedirect(max int) func(*http.Request, []*http.Request) error {
 	return func(_ *http.Request, via []*http.Request) error {
-		if len(via) > *max {
-			return http.ErrUseLastResponse
+		if len(via) > max {
+			return fmt.Errorf("stopped after %d redirects", max)
 		}
 		return nil
 	}

config/confighttp/confighttp_test.go

@@ -337,36 +337,36 @@ func TestHTTPClientSettingsError(t *testing.T) {
 }
 
 func TestMaxRedirects(t *testing.T) {
-	toIntPtr := func(i int) *int {
-		return &i
-	}
 	tests := []struct {
 		name             string
 		settings         ClientConfig
 		expectedRequests int
 		expectedErrStr   string
 	}{
 		{
-			name:             "No redirects config",
-			settings:         ClientConfig{},
-			expectedRequests: 10,
+			name:             "No redirects config (Default Go max redirects)",
+			settings:         NewDefaultClientConfig(),
+			expectedRequests: 11,
 			// default client returns an error, custom implementations should return a ErrUseLastResponse which the internal http package will skip it to let the users select the previous response without closing the body.
 			expectedErrStr: "stopped after 10 redirects",
 		},
 		{
 			name:             "Zero redirects",
-			settings:         ClientConfig{MaxRedirects: toIntPtr(0)},
+			settings:         ClientConfig{MaxRedirects: 0},
 			expectedRequests: 1,
+			expectedErrStr: "stopped after 0 redirects",
 		},
 		{
 			name:             "One redirect",
-			settings:         ClientConfig{MaxRedirects: toIntPtr(1)},
+			settings:         ClientConfig{MaxRedirects: 1},
 			expectedRequests: 2,
+			expectedErrStr: "stopped after 1 redirects",
 		},
 		{
 			name:             "Defined max redirects",
-			settings:         ClientConfig{MaxRedirects: toIntPtr(5)},
+			settings:         ClientConfig{MaxRedirects: 5},
 			expectedRequests: 6,
+			expectedErrStr: "stopped after 5 redirects",
 		},
 	}