[exporter/datadogexporter] Migrating datadog exporter to use aws sdk v2 #36797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZiHaN
requested review from
dashpole,
a team,
mx-psi and
songy23
as code owners
github-actions
bot
added
exporter/datadog
github-actions
bot
requested review from
Aneurysm9,
ankitpatel96,
dineshg13,
jade-guiton-dd,
liustanley and
mackjmr
LZiHaN
commented
Dec 12, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &Provider{ | ||
| logger: logger, | ||
| detector: ec2provider.NewProvider(sess), | ||
| detector: ec2provider.NewProvider(cfg), |
There was a problem hiding this comment.
The datadogexporter depends on the NewProvider function from metadataproviders, and the resourcedetectionprocessor also relies on the same function.
|
@LZiHaN can you fix the merge conflict? Otherwise the tests won't run |
# Conflicts: # internal/metadataproviders/go.mod
done. |
|
Looks like there are some linting errors, could you take a look at those? |
…ollector-contrib into migrate-to-sdk-v2
I’ve addressed the linting errors and tested everything locally. Please feel free to let me know if there’s anything else I should take a look at! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrating datadog exporter to use aws sdk v2
Link to tracking issue
refer to #36699
Testing
passes tests.
updated mock client implementations to support the new SDK interfaces.
Documentation
no need to update.