Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChrsMark in k8s components code-owners #36703

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Dec 6, 2024

Based on our discussion with @TylerHelmuth I'm proposing to formally get involved more with the following k8s components:

  • k8scluster receiver
  • k8sobjects receiver
  • k8sevents receiver
  • k8sattributes processor

I have been actively following and reviewing the evolution of these components while also being involved in the K8s SemConv approvers team. Being also involved in the stability work of K8s SemConv will help bridge the gaps more easily.

Some related work:

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Pinging @dmitryax @TylerHelmuth

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also kubeletstats

@ChrsMark
Copy link
Member Author

ChrsMark commented Dec 6, 2024

Also kubeletstats

@TylerHelmuth That's already the case :)

active: [dmitryax, TylerHelmuth, ChrsMark]

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Dec 9, 2024
@mx-psi mx-psi merged commit 5c6ffbb into open-telemetry:main Dec 10, 2024
159 of 160 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 10, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Based on our discussion with @TylerHelmuth I'm proposing to formally get
involved more with the following k8s components:

- k8scluster receiver
- k8sobjects receiver
- k8sevents receiver
- k8sattributes processor

I have been actively following and reviewing the evolution of these
components while also being involved in the [K8s SemConv approvers
team](https://github.com/orgs/open-telemetry/teams/semconv-k8s-approvers).
Being also involved in the stability work of K8s SemConv will help
bridge the gaps more easily.

Some related work: 

- PRs reviewed:
[https://github.com/open-telemetry/opentelemetry-collector-contrib/pulls?q=is%3Apr+[…]2Fk8sobjects%2Creceiver%2Fk8sevents%2Cprocessor%2Fk8sattributes](https://github.com/open-telemetry/opentelemetry-collector-contrib/pulls?q=is%3Apr+reviewed-by%3AChrsMark+label%3Areceiver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents%2Cprocessor%2Fk8sattributes)
- PRs authored:
[https://github.com/open-telemetry/opentelemetry-collector-contrib/pulls?q=is%3Apr+[…]ver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents](https://github.com/open-telemetry/opentelemetry-collector-contrib/pulls?q=is%3Apr+author%3AChrsMark+label%3Aprocessor%2Fk8sattributes%2Creceiver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents)
- Issues created:
[https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Ais[…]er%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents+](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aissue+author%3AChrsMark+label%3Aprocessor%2Fk8sattributes%2Creceiver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents+)
- Issues commented:
[https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Ais[…]er%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents+](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aissue+commenter%3AChrsMark+label%3Aprocessor%2Fk8sattributes%2Creceiver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents+)

Signed-off-by: ChrsMark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore processor/k8sattributes k8s Attributes processor ready to merge Code review completed; ready to merge by maintainers receiver/k8scluster receiver/k8sevents receiver/k8sobjects Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants